Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(breadcrumbs): reinstate dispatch barrier guard #752

Merged
merged 1 commit into from
Jul 13, 2020
Merged

fix(breadcrumbs): reinstate dispatch barrier guard #752

merged 1 commit into from
Jul 13, 2020

Conversation

tomlongridge
Copy link
Contributor

Goal

Restored previous dispatch barrier guard due to reported issue creating a mutable copy. The functionality returns to how it was before #743 for the arrayValue method.

Tests

Repeated tests from #743 - ensuring leaveBreadcrumb and notify could be called in multiple threads on a tight loop.

@fractalwrench fractalwrench merged commit 2e52665 into next Jul 13, 2020
@fractalwrench fractalwrench deleted the tom/reinstate-guard-breadcrumbs-arraycopy branch July 13, 2020 08:56
@tomlongridge tomlongridge restored the tom/reinstate-guard-breadcrumbs-arraycopy branch July 14, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalwrench fractalwrench fractalwrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomlongridge @fractalwrench