Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attachCustomStacktrace from public API #547

Merged
merged 1 commit into from
Apr 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ Bugsnag Notifiers on other platforms.

## Enhancements

* Remove attachCustomStacktrace from public API
[#547](https://github.com/bugsnag/bugsnag-cocoa/pull/547)

* Create structured `BugsnagError` class
[#533](https://github.com/bugsnag/bugsnag-cocoa/pull/533)

Expand Down
6 changes: 0 additions & 6 deletions Source/BugsnagEvent.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,6 @@ initWithErrorName:(NSString *_Nonnull)name
handledState:(BugsnagHandledState *_Nonnull)handledState
session:(BugsnagSession *_Nullable)session;

/**
* Prepend a custom stacktrace with a provided type to the crash report
*/
- (void)attachCustomStacktrace:(NSArray *_Nonnull)frames
withType:(NSString *_Nonnull)type;

// -----------------------------------------------------------------------------
// MARK: - Properties
// -----------------------------------------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions UPGRADING.md
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ of the removed `addAttribute`:
- event.depth
- event.error
- event.isIncomplete
- [event attachCustomStacktrace:type:]

### `BugsnagSession` class

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@
E7767F10221C21D90006648C /* StoppedSessionScenario.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StoppedSessionScenario.swift; sourceTree = "<group>"; };
E7767F12221C21E30006648C /* ResumedSessionScenario.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ResumedSessionScenario.swift; sourceTree = "<group>"; };
E7767F14221C223C0006648C /* NewSessionScenario.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NewSessionScenario.swift; sourceTree = "<group>"; };
E77AFEF72449C6460082B8BB /* AttachCustomStacktraceHook.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AttachCustomStacktraceHook.h; sourceTree = "<group>"; };
EE18B3777C62D7BCA8DDBE30 /* Pods-iOSTestApp.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-iOSTestApp.debug.xcconfig"; path = "Pods/Target Support Files/Pods-iOSTestApp/Pods-iOSTestApp.debug.xcconfig"; sourceTree = "<group>"; };
F42950588CE34967588DF438 /* ObjCExceptionScenario.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ObjCExceptionScenario.h; sourceTree = "<group>"; };
F42950D49A5F24FF7155EEE1 /* NonExistentMethodScenario.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NonExistentMethodScenario.h; sourceTree = "<group>"; };
Expand Down Expand Up @@ -401,6 +402,7 @@
0011E6662403D13100ED71CD /* UserPersistenceScenarios.m */,
0011E6682403D14400ED71CD /* UserPersistenceScenarios.h */,
00507A63242BFE5600EF1B87 /* EnabledBreadcrumbTypesIsNilScenario.swift */,
E77AFEF72449C6460082B8BB /* AttachCustomStacktraceHook.h */,
);
path = scenarios;
sourceTree = "<group>";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@

#import <Bugsnag/Bugsnag.h>
#import "Scenario.h"
#import "AttachCustomStacktraceHook.h"
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
//
// AttachCustomStacktraceHook.h
// iOSTestApp
//
// Created by Jamie Lynch on 17/04/2020.
// Copyright © 2020 Bugsnag. All rights reserved.
//

#import <Foundation/Foundation.h>
#import <Bugsnag/Bugsnag.h>

@interface BugsnagEvent ()
- (void)attachCustomStacktrace:(NSArray *)frames withType:(NSString *)type;
@end