Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to build when using Carthage #423

Merged
merged 5 commits into from
Oct 16, 2019

Conversation

kattrali
Copy link
Contributor

Making the Bugsnag framework universal introduced an issue where the framework fails to build because of a framework linking issue where Cocoa.framework was included in the iOS build. This change resolves that issue, as well as a misleading issue where building for iOS would use OSX.xcworkspace, which is usable but potentially confusing.

There is one remaining issue. When building the framework, it will appear to build three times and then succeed, with output similar to this:

$ carthage update --platform ios
*** Cloning bugsnag-cocoa
*** Checking out bugsnag-cocoa at "d65082be79ead9908017e270f53a6d32fe41f5f3"
*** xcodebuild output can be found in /var/folders/5g/5fznsq314k94wlj5n0l2xph40000gn/T/carthage-xcodebuild.2rIVXB.log
*** Building scheme "Bugsnag" in Bugsnag.xcodeproj
*** Building scheme "Bugsnag" in Bugsnag.xcodeproj
*** Building scheme "Bugsnag" in Bugsnag.xcodeproj

This is an easily fixable issue by consolidating into a single Xcode project, however it has potential implications for people integrating bugsnag-cocoa as a git submodule or other vendoring solution, which could break if the project files are moved around. I've opted to wait on that change for now to determine the best way integrate everyone and write upgrade instructions.

Testing

  • Tested manually against iOS / tvOS / and macOS projects using Carthage
  • Added a new CI phase to build the repository with Carthage

Fixes #418

@Sidetalker Sidetalker mentioned this pull request Oct 10, 2019
12 tasks
@kattrali kattrali force-pushed the kattrali/fix-carthage-build-short-term branch from 6d76560 to b9c44db Compare October 15, 2019 12:17
Fixes an issue where cocoa.framework is being requested from iOS builds
@kattrali kattrali force-pushed the kattrali/fix-carthage-build-short-term branch 2 times, most recently from 87c0f25 to 8b6dcbc Compare October 16, 2019 10:26
Also reduces confusion where Carthage may pick "OSX.xcworkspace" to
build for an iOS project
@kattrali kattrali force-pushed the kattrali/fix-carthage-build-short-term branch 2 times, most recently from a8962a9 to 9d3ba16 Compare October 16, 2019 10:33
@kattrali kattrali force-pushed the kattrali/fix-carthage-build-short-term branch from d793dc2 to d842248 Compare October 16, 2019 14:15
@bugsnag bugsnag deleted a comment from codecov bot Oct 16, 2019
@kattrali kattrali merged commit d842248 into master Oct 16, 2019
@kattrali kattrali deleted the kattrali/fix-carthage-build-short-term branch October 16, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can't install Bugsnag on Carthage + Xcode11
1 participant