Fix failure to build when using Carthage #423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the Bugsnag framework universal introduced an issue where the framework fails to build because of a framework linking issue where Cocoa.framework was included in the iOS build. This change resolves that issue, as well as a misleading issue where building for iOS would use
OSX.xcworkspace
, which is usable but potentially confusing.There is one remaining issue. When building the framework, it will appear to build three times and then succeed, with output similar to this:
This is an easily fixable issue by consolidating into a single Xcode project, however it has potential implications for people integrating bugsnag-cocoa as a git submodule or other vendoring solution, which could break if the project files are moved around. I've opted to wait on that change for now to determine the best way integrate everyone and write upgrade instructions.
Testing
Fixes #418