fix(oom): Ensure UIKit APIs are not called from background threads #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The normal flow is to install on the main thread, immediately after app launch to ensure as many errors and crashes are captured as possible. However, some mobile development frameworks may prevent this flow, instead only allowing initialization later or on a background queue. In these cases, the library should still work and not emit additional warnings. Prior to this change, background initialization using Bugsnag.start() would be detected by the main thread sanitizer as UI API usage.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normal flow is to install on the main thread, immediately after app
launch to ensure as many errors and crashes are captured as possible.
However, some mobile development frameworks may prevent this flow,
instead only allowing initialization later or on a background queue. In
these cases, the library should still work and not emit additional
warnings.
Prior to this change, background initialization using Bugsnag.start()
would be detected by the main thread sanitizer as UI API usage.
Fixes bugsnag/bugsnag-react-native#396
Tests
While I didn't find a good way to automate the check (as it only fires in an interactive debugging environment), I verified the change manually to ensure that it is only called on main now.