Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support adding pre-delivery metadata to OOM reports #393

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

kattrali
Copy link
Contributor

@kattrali kattrali commented Jul 22, 2019

It is currently not possible to append additional metadata in before send callbacks, only override completely, which is different than the normal behavior. This change amends the behavior to ensure that adding metadata works as expected.

Fixes #392

@kattrali kattrali force-pushed the kattrali/fix-missing-custom-metadata branch from 5279955 to 849343c Compare July 22, 2019 13:45
@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #393 into master will decrease coverage by 0.69%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #393     +/-   ##
=========================================
- Coverage   51.91%   51.21%   -0.7%     
=========================================
  Files          66       66             
  Lines        8937     8938      +1     
=========================================
- Hits         4640     4578     -62     
- Misses       4297     4360     +63
Impacted Files Coverage Δ
Source/BugsnagCrashReport.m 82.34% <0%> (-0.17%) ⬇️
...SCrash/Recording/Tools/BSG_KSCrashCallCompletion.m 0% <0%> (-100%) ⬇️
Source/BugsnagErrorReportApiClient.m 13.33% <0%> (-73.34%) ⬇️
Source/BugsnagLogger.h 66.66% <0%> (-33.34%) ⬇️
...rce/KSCrash/Source/KSCrash/Recording/BSG_KSCrash.m 36.5% <0%> (-10.27%) ⬇️
...rash/Source/KSCrash/Recording/Tools/BSG_KSLogger.h 50% <0%> (-10%) ⬇️
Source/BugsnagSessionTrackingApiClient.m 78.72% <0%> (-8.52%) ⬇️
Source/BugsnagFileStore.m 60% <0%> (-7.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e8a82...849343c. Read the comment docs.

@kattrali kattrali merged commit 7235fde into master Jul 24, 2019
@kattrali kattrali deleted the kattrali/fix-missing-custom-metadata branch July 24, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta data cannot be set for SIGKILL based errors
2 participants