fix(oom): Report short version as app.version #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeHex
reviewed
May 21, 2019
| @@ -214,7 +214,7 @@ - (NSMutableDictionary *)generateCacheInfoWithConfig:(BugsnagConfiguration *)con | |||
| app[@"id"] = systemInfo[@BSG_KSSystemField_BundleID] ?: @""; | |||
| app[@"name"] = systemInfo[@BSG_KSSystemField_BundleName] ?: @""; | |||
| app[@"releaseStage"] = config.releaseStage; | |||
| app[@"version"] = systemInfo[@BSG_KSSystemField_BundleVersion] ?: @""; | |||
| app[@"version"] = systemInfo[@BSG_KSSystemField_BundleShortVersion] ?: @""; | |||
There was a problem hiding this comment.
Do we want to add the bundle version in as well? Think it would something like
app[@"bundleVersion"] = systemInfo[@BSG_KSSystemField_BundleVersion] ?: @"";
There was a problem hiding this comment.
Yeah - having both makes sense 👍
| @@ -155,7 +155,7 @@ - (BOOL)computeDidOOMLastLaunchWithConfig:(BugsnagConfiguration *)config { | |||
| NSString *osVersion = [BSG_KSSystemInfo osBuildVersion]; | |||
| NSDictionary *appInfo = [[NSBundle mainBundle] infoDictionary]; | |||
| NSString *appVersion = | |||
| [appInfo valueForKey:(__bridge NSString *)kCFBundleVersionKey]; | |||
| [appInfo valueForKey:@BSG_KSSystemField_BundleShortVersion]; | |||
There was a problem hiding this comment.
If this is being used to detect if the app has the same version and hence report the OOM, should this be on app version and bundle version rather than just app version?
There was a problem hiding this comment.
That's a good question. The safest thing is to check both, so I'll make it do that.
Add bundleVersion as separate field
kattrali
force-pushed
the
kattrali/fix-app-version-oom-reports
branch
from
3ad37fc to
cfeb982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out-of-memory reports are incorrectly reporting the build number as the version number. This change fixes that error and adds a few assertions for it in OOM report tests.