-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle nil content value #289
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dfa76aa
test: add test coverage for RegisterErrorData errorDataFromThreads:
fractalwrench 64246ed
fix: nil check content value to prevent crash
fractalwrench a5ab8bf
docs: add changelog entry for nil content value
fractalwrench 2aab177
test: add explicit test case for NSNull and check type of value
fractalwrench File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,248 @@ | ||
| // | ||
| // Created by Jamie Lynch on 11/06/2018. | ||
| // Copyright (c) 2018 Bugsnag. All rights reserved. | ||
| // | ||
|
|
||
|
|
||
| #import <Foundation/Foundation.h> | ||
| #import <XCTest/XCTest.h> | ||
|
|
||
| @interface RegisterErrorData | ||
| + (instancetype)errorDataFromThreads:(NSArray *)threads; | ||
| @property (nonatomic, strong) NSString *errorClass; | ||
| @property (nonatomic, strong) NSString *errorMessage; | ||
| @end | ||
|
|
||
| @interface RegisterErrorDataTest : XCTestCase | ||
| @end | ||
|
|
||
| @implementation RegisterErrorDataTest | ||
|
|
||
|
|
||
| - (void)testNilAddresses { | ||
| XCTAssertNil([RegisterErrorData errorDataFromThreads:nil]); | ||
| } | ||
|
|
||
| - (void)testEmptyAddresses { | ||
| XCTAssertNil([RegisterErrorData errorDataFromThreads:@[]]); | ||
| } | ||
|
|
||
| - (void)testEmptyCrashedThreadDict { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES | ||
| }; | ||
| XCTAssertNil([RegisterErrorData errorDataFromThreads:@[thread]]); | ||
| } | ||
|
|
||
| - (void)testEmptyNotableAddresses { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{} | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertNil(data); | ||
| } | ||
|
|
||
| - (void)testEmptyContentValue { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{} | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertNil(data); | ||
| } | ||
|
|
||
| - (void)testHasType { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertNil(data); | ||
| } | ||
|
|
||
| - (void)testHasTypeAndValue{ | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string", | ||
| @"value": @"Hello, World!" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertNil(data); | ||
| } | ||
|
|
||
| - (void)testFatalError { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string", | ||
| @"value": @"fatal error" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertNotNil(data); | ||
| XCTAssertEqualObjects(@"fatal error", data.errorClass); | ||
| XCTAssertEqualObjects(@"", data.errorMessage); | ||
| } | ||
|
|
||
| - (void)testAssertionFailed { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string", | ||
| @"value": @"assertion failed" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertNotNil(data); | ||
| XCTAssertEqualObjects(@"assertion failed", data.errorClass); | ||
| XCTAssertEqualObjects(@"", data.errorMessage); | ||
| } | ||
|
|
||
| - (void)testPreconditionFailed { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string", | ||
| @"value": @"precondition failed" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertNotNil(data); | ||
| XCTAssertEqualObjects(@"precondition failed", data.errorClass); | ||
| XCTAssertEqualObjects(@"", data.errorMessage); | ||
| } | ||
|
|
||
| - (void)testSingleMessageValue { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string", | ||
| @"value": @"fatal error" | ||
| }, | ||
| @"message": @{ | ||
| @"type": @"string", | ||
| @"value": @"Single Message" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertEqualObjects(@"Single Message", data.errorMessage); | ||
| } | ||
|
|
||
| - (void)testMultiMessageValue { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string", | ||
| @"value": @"fatal error" | ||
| }, | ||
| @"message": @{ | ||
| @"type": @"string", | ||
| @"value": @"A is for aardvark" | ||
| }, | ||
| @"message2": @{ | ||
| @"type": @"string", | ||
| @"value": @"Z is for zebra" | ||
| }, | ||
| @"message3": @{ | ||
| @"type": @"string", | ||
| @"value": @"C is for crayfish" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertEqualObjects(@"A is for aardvark | C is for crayfish | Z is for zebra", data.errorMessage); | ||
| } | ||
|
|
||
| - (void)testStackExcluded { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string", | ||
| @"value": @"fatal error" | ||
| }, | ||
| @"message": @{ | ||
| @"type": @"stack", | ||
| @"value": @"0xf0924501" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertEqualObjects(@"", data.errorMessage); | ||
| } | ||
|
|
||
| - (void)testOtherTypesExcluded { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string", | ||
| @"value": @"fatal error" | ||
| }, | ||
| @"message": @{ | ||
| @"type": @"someOtherType", | ||
| @"value": @"do not serialise" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertEqualObjects(@"", data.errorMessage); | ||
| } | ||
|
|
||
| - (void)testFilepathExcluded { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string", | ||
| @"value": @"fatal error" | ||
| }, | ||
| @"message": @{ | ||
| @"type": @"string", | ||
| @"value": @"/usr/share/locale" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertEqualObjects(@"", data.errorMessage); | ||
| } | ||
|
|
||
| - (void)testForwardSlashIncluded { | ||
| NSDictionary *thread = @{ | ||
| @"crashed": @YES, | ||
| @"notable_addresses": @{ | ||
| @"hello_world": @{ | ||
| @"type": @"string", | ||
| @"value": @"fatal error" | ||
| }, | ||
| @"message": @{ | ||
| @"type": @"string", | ||
| @"value": @"usr/share" | ||
| } | ||
| } | ||
| }; | ||
| RegisterErrorData *data = [RegisterErrorData errorDataFromThreads:@[thread]]; | ||
| XCTAssertEqualObjects(@"usr/share", data.errorMessage); | ||
| } | ||
|
|
||
| @end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change just simplifies the condition to make it more readable