Improve minimal report app/device information #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
suggested changes
Feb 12, 2018
Source/BugsnagSink.m
Outdated
| bugsnagReport.app = @{ | ||
| @"bundleVersion": sysInfo[@BSG_KSSystemField_BundleVersion], | ||
| @"id": sysInfo[@BSG_KSSystemField_BundleID], | ||
| @"releaseStage": configuration.releaseStage, |
There was a problem hiding this comment.
There is a risk here for any of these values to be nil, particularly release stage if overridden by the user, so inserting values only if not nil would be prudent here as this will otherwise crash if any of these values is not set.
|
Should we add tests for this functionality? |
|
We plan to add a mazerunner scenario which will cover this test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes report generation so that when a minimal or incomplete crash is recorded, essential app/device information is included in the report on the next startup.
Partially addresses #224