Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crash while reporting user exception #234

Merged
merged 1 commit into from
Jan 24, 2018
Merged

fix crash while reporting user exception #234

merged 1 commit into from
Jan 24, 2018

Conversation

paulz
Copy link
Contributor

@paulz paulz commented Jan 23, 2018

Fixes #233 update expected CPU Architecture

fix crash while reporting user exception
85402f0 
update expected cpu arch
@kattrali
Copy link
Contributor

Thank you for the fix, @paulz. I've confirmed that it fixes #233. I'm going to add some additional handling as even an unknown arch shouldn't crash the register parser.

@paulz
Copy link
Contributor Author

paulz commented Jan 23, 2018

And thank you @kattrali for quick response! and thank you Bugsnag for snagging our bugs!

@kattrali kattrali merged commit 85402f0 into bugsnag:master Jan 24, 2018
kattrali added a commit that referenced this pull request Jan 24, 2018
@kattrali
handle unknown CPU archs, improve error messaging (#235) (#234)
a1e3f76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulz @kattrali