Plat 12250 build xcframeworks #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated by 🚫 Danger |
| @@ -89,6 +89,9 @@ build_ios_static: ## Build the static library target | |||
| build_carthage: ## Build the latest pushed commit with Carthage | |||
| @./scripts/build-carthage.sh | |||
|
|
|||
| build_xcframework: ## Build as a multiplatform xcframework | |||
There was a problem hiding this comment.
nit: The Make target calls it xcframework but the script just uses framework. Maybe less likely to trip people up if we us framework for both? I can change it on the PR to add it to CI, so long as you agree.
There was a problem hiding this comment.
Oh, it's actually building an xcframework, so best to settle on that I guess
There was a problem hiding this comment.
Yeah, I don't mind at all which one is used, I'm just likely to forget and get them wrong if they aren't the same - I'll chang eit to xc when I get to it no problem.
There was a problem hiding this comment.
Everything should be xcframework now
kstenerud
force-pushed
the
PLAT-12250-build-xcframeworks
branch
from
390d495 to
608fe47
Compare
twometresteve
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR adds the ability to build the binary xcframework from the command line.