Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait longer for the macOS test fixture to stop running #1662

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

twometresteve
Copy link
Contributor

Goal

Attempt to reduce test flakes by waiting longer for crash reports to be written.

Design

I've noticed some test flakes recently where internal errors were being sent to Maze Runner due to invalid (truncated) crash report files. It seem that the lsappinfo mechanism we were using to detect the app stopping running was not reliably giving enough time for crash reports to be written, so I have fallen back to a simple wait instead.

Testing

Before this change, I could hardly get the RecrashObjcMachScenario to pass at all - after the change it passed 20/20 times. The down side of this change is that does increase the length of test runs from about 20 to 24 minutes.

@twometresteve twometresteve requested a review from kstenerud June 13, 2024 15:09
Copy link

Bugsnag.framework binary size did not change - 718,176 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@twometresteve twometresteve merged commit 0cb6388 into next Jun 14, 2024
40 checks passed
@twometresteve twometresteve deleted the tms/relaunch-crash branch June 14, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants