Wait longer for the macOS test fixture to stop running #1662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Attempt to reduce test flakes by waiting longer for crash reports to be written.
Design
I've noticed some test flakes recently where internal errors were being sent to Maze Runner due to invalid (truncated) crash report files. It seem that the
lsappinfo
mechanism we were using to detect the app stopping running was not reliably giving enough time for crash reports to be written, so I have fallen back to a simple wait instead.Testing
Before this change, I could hardly get the
RecrashObjcMachScenario
to pass at all - after the change it passed 20/20 times. The down side of this change is that does increase the length of test runs from about 20 to 24 minutes.