Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in e2e test run #1656

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Fix error in e2e test run #1656

merged 2 commits into from
Jun 4, 2024

Conversation

twometresteve
Copy link
Contributor

Goal

Fixes an ugly but benign error in the e2e test runs.

Design

The error resulted from a port not being exposed for the document server, but there are 2 instances of it and we use the other.

Testing

Covered by a basic CI run.

@twometresteve twometresteve requested a review from kstenerud May 30, 2024 17:03
@github-actions GitHub Actions
Copy link

Bugsnag.framework binary size did not change - 718,176 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@twometresteve twometresteve merged commit 39c1a64 into next Jun 4, 2024
37 checks passed
@twometresteve twometresteve deleted the tms/port-error branch June 4, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstenerud kstenerud kstenerud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twometresteve @kstenerud