Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-11642] BugsnagSessionTracker race condition #1632

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

kstenerud
Copy link
Contributor

Goal

BugsnagSessionTracker.extraRuntimeInfo was not protected from asynchronous access, potentially crashing RN apps.

Changeset

Added @synchronized to protect the dictionary.

Testing

Added unit test.

Copy link

Bugsnag.framework binary size increased by 56 bytes from 713,208 to 713,264

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +120  +0.1%    +120    __TEXT,__text
  +0.0%     +32  +0.0%     +32    Symbol Table
  +1.0%     +32  +1.0%     +32    __TEXT,__gcc_except_tab
  +0.0%     +24  +0.0%     +24    String Table
  +0.4%     +12  +0.4%     +12    __TEXT,__unwind_info
  [ = ]       0  -0.7%     -56    [__LINKEDIT]
  -0.9%    -164  -0.9%    -164    [__TEXT]
  +0.0%     +56  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud merged commit 920af29 into next Feb 27, 2024
33 checks passed
@kstenerud kstenerud deleted the PLAT-11642-bugsnagsessiontracker-race-condition branch February 27, 2024 17:07
@kstenerud kstenerud mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants