Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-4590] Remove introspection code #1437

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

nickdowell
Copy link
Contributor

Goal

Remove code related to KSCrash's introspection functionality which we no longer use.

Changeset

Removes KSCrash's introspectMemory functionality.

Removes BSG_KSCrashField_ReferencedObject "referenced_object" and related code - it was not being used anywhere.

Removes unused functionality from BSG_KSCrashDoctor:

  • The doctor is not called for NSExceptions, so removes that code.
  • Simplifies returned strings - anything beyond \n was being ignored.
  • Removes unused methods.

Testing

Verified no change in payloads via E2E and unit tests.

@nickdowell nickdowell requested review from kstenerud and kattrali July 15, 2022 11:05
@github-actions
Copy link

Bugsnag.framework binary size decreased by 9,512 bytes from 814,480 to 804,968 🎉

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  +202% +9.29Ki    [__LINKEDIT]
   +24% +5.02Ki   +24% +5.02Ki    [__TEXT]
  -3.2%     -32  -3.2%     -32    __DATA,__objc_ivar
  -1.5%     -32  -1.5%     -32    __TEXT,__const
  -0.9%     -30  -0.3%     -38    [3 Others]
  -2.1%     -40  -2.1%     -40    Function Start Addresses
  -1.4%     -48  -1.4%     -48    __TEXT,__unwind_info
  -2.8%     -56  -2.8%     -56    Rebase Info
  -0.8%     -56  -0.8%     -56    __DATA,__objc_selrefs
  -4.9%     -56  -4.9%     -56    __TEXT,__objc_classname
  -3.6%    -128  -3.6%    -128    __TEXT,__gcc_except_tab
  -4.3%    -160  -4.3%    -160    __DATA,__objc_data
  -4.0%    -368  -4.0%    -368    Export Info
  -2.5%    -477  -2.5%    -477    __TEXT,__cstring
  -2.3%    -642  -2.3%    -642    __TEXT,__objc_methname
  -5.7% -1.16Ki  -5.7% -1.16Ki    __DATA,__cfstring
  -2.7% -1.32Ki  -2.7% -1.32Ki    __DATA,__objc_const
  -1.5% -3.66Ki  -1.5% -3.66Ki    __TEXT,__text
  -2.6% -3.78Ki  -2.6% -3.78Ki    Symbol Table
  -2.8% -5.05Ki  -2.8% -5.05Ki    String Table
   +34% +2.73Ki -91.5% -13.3Ki    [__DATA]
  -1.2% -9.29Ki  -2.0% -16.0Ki    TOTAL

Generated by 🚫 Danger

@nickdowell nickdowell merged commit b0fcd56 into next Jul 18, 2022
@nickdowell nickdowell deleted the nickdowell/remove-introspection-code branch July 18, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants