Fix accidental rename of beforeSendBlocks #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kattrali can you help me figure out why the Travis build is failing? |
spikebrehm
force-pushed
the
fix-beforesendblocks-name
branch
from
3bc276b to
55890cf
Compare
|
Ok this test run, the tests passed, but I'm getting this error: |
|
Definitely looks like Travis' problem. The tests pass for me locally, and I added a few more specific to this case. |
kattrali
added a commit
that referenced
this pull request
Nov 8, 2016
* Fix renamed property * Add specs for global blocks behavior
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like in this commit:
3bf80c9#diff-31f3ba7de1042a9da5dca47128578247R48
which was meant to clean up naming of the blocks, there was an accidental mis-renaming of the
_beforeSendBlocksvariable, which causesaddBeforeSendBlockto silently fail 😢 .to: @kattrali