[PLAT-7635] check nil parameter in network breadcrumbs #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
changed the title
nickdowell
reviewed
Nov 17, 2021
BugsnagNetworkRequestPlugin/BugsnagNetworkRequestPlugin/BSGURLSessionTracingDelegate.m
Outdated
Show resolved
Hide resolved
kstenerud
force-pushed
the
PLAT-7635-nil-parameter
branch
from
75cb965 to
5097aa0
Compare
nickdowell
reviewed
Nov 18, 2021
BugsnagNetworkRequestPlugin/BugsnagNetworkRequestPlugin.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
BugsnagNetworkRequestPlugin/BugsnagNetworkRequestPlugin/BSGURLSessionTracingDelegate.m
Outdated
Show resolved
Hide resolved
kstenerud
force-pushed
the
PLAT-7635-nil-parameter
branch
from
5097aa0 to
740c26b
Compare
…gainstBaseURL:] is not nil
kstenerud
force-pushed
the
PLAT-7635-nil-parameter
branch
from
740c26b to
fb1764f
Compare
nickdowell
approved these changes
Nov 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple metrics via the Apple API might not have a request object, or the request might not have a URL. We need to check before trying to use them.
Also made the request search more robust since there can be many possible places for them, and not all of them will have an HTTP body.
Testing
Unfortunately we don't have a repro case for the report that triggered this issue, but the existing tests all pass.