Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-7263] Disable app hang detection in app extensions #1198

Merged

Conversation

nickdowell
Copy link
Contributor

Goal

App extensions have a different life cycle and environment that make the hang detection mechanism unsuitable.

  • Depending on the type of extension, the run loop is not necessarily dedicated to UI.
  • The host app or other extensions run by it may trigger false positives.
  • The system may kill app extensions without any notification.

Changeset

Disables app hang detection in app extensions.

Improves the logic of +[BSG_KSSystemInfo isRunningInAppExtension] by querying the Info.plist's NSExtensionPointIdentifier rather than CFBundlePackageType (which would erroneously cause YES to be returned for some versions of Xcode's xctest unit test runner.)

Testing

Manually verified in a Widget app extension.

CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,156,600 bytes

Generated by 🚫 Danger

@nickdowell nickdowell force-pushed the nickdowell/disable-app-hang-detection-in-app-extensions branch from 29897b3 to 3bbd394 Compare September 29, 2021 12:14
@nickdowell nickdowell force-pushed the nickdowell/disable-app-hang-detection-in-app-extensions branch from 3bbd394 to bd5bc47 Compare September 29, 2021 12:15
@nickdowell nickdowell merged commit 2aa2e51 into next Sep 30, 2021
@nickdowell nickdowell deleted the nickdowell/disable-app-hang-detection-in-app-extensions branch September 30, 2021 09:00
@nickdowell nickdowell mentioned this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants