[PLAT-6708] Stop app hangs being reported if app is launched in the background #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The intention behind #1075 was to ignore all app hangs that occur while an app in is the background. The initial state of the app was not being taken into account, though, resulting in app hags being reported if an app is launched for a background fetch or other background activity.
Changeset
The app hang detector now uses
applicationIsInForegroundfromBSG_KSCrash_Statewhich is correctly initialised at start-up.Updated
BSG_KSCrash.mto ensure theapplicationIsInForegroundvalue is updated even is none of KSCrash's sentries are installed.Testing
Tested manually. Not tested via E2E because it's not possible to trigger a background launch via Appium.