[PLAT-6627] Improve performance of bsg_mach_headers_image_at_address #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Reduce overhead of calling
Bugsnag.notify()Changeset
bsg_mach_headers_image_at_addressnow only compares the passed in address against the__TEXTsegment of each image (using its precomputedimageSizevalue.)This improves performance but means only addresses of executable code will be resolved. Since we only use this function against instruction addresses, this should not present a problem.
Testing
Tested via unit and E2E tests.
In a simple test app, performance per call to
notify()has been reduced from 3.8 ms to 2.8 ms 🎉