Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-6628] Cache systemInfo values to improve performance #1104

Merged
merged 9 commits into from
Jun 1, 2021

Conversation

nickdowell
Copy link
Contributor

Goal

Reduce overhead of calling Bugsnag.notify()

Changeset

The majority of values are now computed once and stored in a static NSDictionary.

Removed values that are not used anywhere.

Testing

Tested via unit and E2E tests.

@nickdowell nickdowell requested review from kstenerud and kattrali June 1, 2021 09:11
@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size decreased by 1,112 bytes from 1,127,672 to 1,126,560 🎉

Generated by 🚫 Danger

@nickdowell nickdowell merged commit c17efdf into next Jun 1, 2021
@nickdowell nickdowell deleted the nickdowell/system-info-caching branch June 1, 2021 10:44
@nickdowell nickdowell mentioned this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants