[PLAT-6339] Add binaryArch and runningOnRosetta to app metadata #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nickdowell
force-pushed
the
nickdowell/binary-arch
branch
from
8db6d1e to
12d6302
Compare
kstenerud
approved these changes
Apr 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allows Mac developers to identify which code slice from a Universal binary was running when an error occurred, and identify errors that may be specific to Rosetta.
Changeset
Adds
binaryArchandrunningOnRosettato theappmetadata.Removes
BSG_KSSystemField_BinaryCPUTypeandBSG_KSSystemField_BinaryCPUSubTypesince they are unused.Testing
Manually tested using example apps and verified new fields appear on dashboard.
Amended E2E test scenario to verify presence of
binaryArch