-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record storagemanager cache behaviour in internal error reports #588
Conversation
bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java
Outdated
Show resolved
Hide resolved
I've updated the PR to get the tombstone behaviour directly from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some automated tests to check the fields are set in the internal error report?
…rify more payload data
5faf9fc
to
4f272ab
Compare
I've updated the mazerunner scenario for an internal error report to check the storagemanager cache values are set, and to more generally validate other fields that we add to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments on one scenario, though the commentary (mostly) applies to both.
9ad18fb
to
05f2b42
Compare
05f2b42
to
0a45f7a
Compare
I have updated the internal_report feature to run 3 scenarios:
I have also updated the assertion steps as requested. |
Goal
Android API 26 introduced
setCacheBehaviorGroup
, which tells the OS to delete all the files in a given directory if space needs reclaiming. Coupled withsetCacheBehaviorTombstone
which truncates files to 0, this could explain the volume of minimal error reports reported by some customers.We should record this information in our internal error diagnostics to debug the issue further.
Tests
Tested against a local artefact on API 23 + 29 which had been altered to always call
recordStorageCacheBehavior
when notifying.