Improve Bugsnag.start thread-safety
#1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-4420/bugsnag-start-thread-safety
branch
from
0fc3558 to
a6dca4e
Compare
… functions are safe to call while `Bugsnag.start` is still running
lemnik
force-pushed
the
PLAT-4420/bugsnag-start-thread-safety
branch
from
a6dca4e to
22fc60e
Compare
kattrali
approved these changes
Mar 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allow Bugsnag functions (
notify,leaveBreadcrumb,addMetadata, etc.) to be safely invoked from background threads, whileBugsnag.startis still running.The additional lock makes late & multi-threaded startup safe.
Testing
Added an end-to-end test that flakes (typically failing) when the additional lock is not in place.