Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-8185] Limit retries of event payloads based on size and age, and session payloads based on age #1633

Merged
merged 2 commits into from
Mar 30, 2022
Merged

[PLAT-8185] Limit retries of event payloads based on size and age, and session payloads based on age #1633

merged 2 commits into from
Mar 30, 2022

Conversation

kstenerud
Copy link
Contributor

Goal

To prevent the buildup of old or large files, event and session files will be deleted on a failed send if they meet certain criteria:

  • Events if they are older than 60 days or larger than 1MB
  • Sessions if they are older than 60 days

Testing

New e2e tests

@kstenerud kstenerud requested a review from lemnik March 21, 2022 15:58
@kstenerud kstenerud force-pushed the PLAT-8185-delete-old-big-events branch 2 times, most recently from d30897a to e22bdea Compare March 21, 2022 16:02
@tomlongridge tomlongridge mentioned this pull request Mar 21, 2022
Merged
@twometresteve
Copy link
Contributor

As this touches some of the low-level routines, I would ensure that a full CI run has been performed before merging this PR (just include [full ci] in the commit message).

@twometresteve twometresteve mentioned this pull request Mar 22, 2022
Merged
@twometresteve
Copy link
Contributor

@kstenerud I hope you don't mind, but I have taken the liberty of updating updating your branch from next, as I want to chain a reformatting changing onto this PR (all should become apparent shortly!).

@kstenerud kstenerud force-pushed the PLAT-8185-delete-old-big-events branch 2 times, most recently from 01e7729 to b568b41 Compare March 28, 2022 11:57
@kstenerud kstenerud requested a review from lemnik March 28, 2022 11:58
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Mar 28, 2022 •
edited
Loading

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1855.2 1606.38
arm64_v8a 651.66 401.8
armeabi_v7a 586.13 340.37
x86 725.37 479.61
x86_64 692.61 446.85

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the PLAT-8185-delete-old-big-events branch 2 times, most recently from 293c614 to bae9a08 Compare March 29, 2022 08:28
lemnik
lemnik approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kstenerud kstenerud force-pushed the PLAT-8185-delete-old-big-events branch 3 times, most recently from e3daa0e to 67c46e6 Compare March 30, 2022 07:32
@kstenerud kstenerud force-pushed the PLAT-8185-delete-old-big-events branch from 67c46e6 to 8e327e0 Compare March 30, 2022 07:47
@kstenerud kstenerud merged commit 51b7eae into next Mar 30, 2022
@kstenerud kstenerud deleted the PLAT-8185-delete-old-big-events branch March 30, 2022 12:45
@lemnik lemnik mentioned this pull request Mar 31, 2022
Merged
@imjoehaines imjoehaines mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemnik lemnik lemnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kstenerud @twometresteve @bugsnagbot @lemnik