Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden ndk layer through use of const keyword #1566

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

fractalwrench
Copy link
Contributor

Goal

Updates the NDK layer to use const in a few places where it could be using the keyword.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench changed the title Harden ndk layer with use of const Harden ndk layer through use of const keyword Dec 21, 2021
@fractalwrench fractalwrench force-pushed the PLAT-6037/const-hardening branch from d6320c9 to 916c06e Compare December 21, 2021 12:13
@fractalwrench fractalwrench force-pushed the PLAT-6037/const-hardening branch from 916c06e to 3e02e62 Compare December 21, 2021 13:35
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1353.3 1168.15
arm64_v8a 483.72 299.4
armeabi -492.59 -21.55
armeabi_v7a 455.06 270.74
x86 520.57 340.35
x86_64 508.29 323.97

Generated by 🚫 Danger

@fractalwrench fractalwrench merged commit ed5ca80 into next Dec 21, 2021
@fractalwrench fractalwrench deleted the PLAT-6037/const-hardening branch December 21, 2021 16:21
@lemnik lemnik mentioned this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants