Persist LastRunInfo and populate app.isLaunching for JVM errors #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-5977/persist-last-run-info
branch
3 times, most recently
from
91d8260 to
9fa4fd2
Compare
fractalwrench
force-pushed
the
PLAT-5977/persist-last-run-info
branch
from
9fa4fd2 to
04ba191
Compare
tomlongridge
reviewed
Mar 1, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/LastRunInfoStore.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/LaunchCrashTracker.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java
Outdated
Show resolved
Hide resolved
fractalwrench
force-pushed
the
PLAT-5977/persist-last-run-info
branch
from
04ba191 to
697da0e
Compare
|
Updated in response to review comments. |
fractalwrench
force-pushed
the
PLAT-5977/persist-last-run-info
branch
from
697da0e to
83ceb47
Compare
tomlongridge
approved these changes
Mar 4, 2021
fractalwrench
force-pushed
the
PLAT-5977/persist-last-run-info
branch
from
83ceb47 to
caa197e
Compare
fractalwrench
merged commit 9087f64
into
integration/road-1175-identify-crashes-on-launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Persists the
LastRunInfoso that previous launch information can be retrieved by the user. This also sets the value ofapp.isLaunchingon JVM events.The implementation of this behaviour for NDK errors will be done in a separate changeset to ease review.
Changeset
LaunchCrashTracker, which tracks the state of whether the application is currently launching or notLastRunInfoStore, which loads and saves theLastRunInfoobject from disk in the key-value formatLastRunInfoto the defaults onClientinitializationLastRunInfowhenever an unhandled exception occurred so that the next launch allows the user to check that the app crashedTesting
Added unit tests for new classes. Updated JVM events to assert that the
app.isLaunchingfield is set to the correct default.E2E tests for the NDK and when
markLaunchCompleted()are called will be added in a separate PR.