Fix enableBugsnag to work with multiple configs #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21 is functional, but doesn't work for cases like:
because all of the
project.bugsnag
statements are evaluated at configuration time--only the most recent one will "stick". I'd previously mistaken this as a closure that was only evaluated at runtime--whoops.It looks like the easiest solution for this is to make use of Groovy's extra properties; we can store the
enableBugsnag
value either on theProductFlavor
itself or on theBuildType
:Then the values won't override each other and we can fetch them when we're applying the plugin to the variant. It looks like this is what Fabric is doing for Crashlytics.
Testing: