fix: support provider api introduced in gradle 4.7 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gradle 4.7 introduced a provider API for lazy evaluation of properties, AGP subsequently changed the API from File to Provider<File> for manifestOutputDir
martin308
approved these changes
Aug 6, 2018
| @@ -4,6 +4,8 @@ import com.android.build.gradle.api.BaseVariant | |||
| import com.android.build.gradle.api.BaseVariantOutput | |||
| import groovy.xml.Namespace | |||
| import org.gradle.api.DefaultTask | |||
| import org.gradle.api.file.Directory | |||
| import org.gradle.api.provider.Provider | |||
There was a problem hiding this comment.
do we support gradle versions less than 4.7? If so would there be an issue with this import when used with gradle < 4.7?
There was a problem hiding this comment.
We support lower than 4.7. The import doesn't seem to be an issue as the mazerunner scenarios pass on CI, which uses gradle <4.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Gradle 4.7 introduced a provider API for lazy evaluation of properties. The AGP subsequently changed the type of the
manifestOutputDirproperty fromFileto Provider. This changeset supports that API change while maintaining backward compatibility.Changeset
If
manifestOutputDiris not aFile, assume it is using the Provider API and coerce it to a file.Tests
Tested manually on an app using AGP 3.1.0 and another app running AGP 3.3.0.
Additionally the mazerunner scenarios were run on AGP 3.0.1, and then updated to also run on AGP 3.3.0. It's worth noting that the
default_libfeature does not pass in the 3.3.0 project - this is thought to be due to a separate issue.Linked issues
#121