Return null instead of throwing of Widget.child does not exist #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrimMaple
requested changes
Nov 26, 2024
src/dlangui/core/collections.d
Outdated
| @@ -248,6 +248,17 @@ struct ObjectList(T) { | |||
| assert(index >= 0 && index < _count, "child index out of range"); | |||
| return _list[index]; | |||
| } | |||
| /// get item by index. Returns null if item not found | |||
| inout(T) tryGet(int index) @safe inout nothrow { | |||
There was a problem hiding this comment.
Is inout really necessary here?
There was a problem hiding this comment.
TBH I didn't think too much about it. I'm following the pattern. Since get is inout I decided to make tryGet inout as well
There was a problem hiding this comment.
After a quick check - yes, inout is indeed necessary
|
Thank you for your work! :) |
|
I think my sleepy head just did something that I didn't intend on - I intended to squash and merge. Welp, sleep is importnat folks x) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #691
I found only one instance of
.childmethod override