Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/dockerfile: remove VOLUME definition #10

Merged
merged 1 commit into from
Nov 18, 2023
Merged

fix/dockerfile: remove VOLUME definition #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/main-tag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ name: Build multiarch image - tag
on:
push:
tags:
- '[0-9]+.[0-9]+.[0-9]+.[0-9]+'

- '[0-9]+-[0-9]+-[0-9]+-[0-9]+'
- '[0-9]+-[0-9]+-[0-9]+-[0-9]+-r[0-9]+'
- '[0-9]+-[0-9]+-[0-9]+-[0-9]+-rc[0-9]+'
workflow_dispatch:

jobs:
Expand Down
7 changes: 4 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,11 @@ COPY --from=tor-builder /tor/src/config/geoip6 /usr/local/share/tor/.
# install transports
COPY --from=obfs-builder /out/obfs4proxy /usr/local/bin/.

# create service dir (we don't define VOLUME because https://github.com/docker-library/mysql/issues/255
# and other issues when running as non-root user)
RUN mkdir -p /run/tor/service && chown -R 1001 /run/tor

# change to non root
USER 1001

# create service dir
VOLUME /run/tor/service

ENTRYPOINT ["/usr/local/bin/tor"]
7 changes: 4 additions & 3 deletions Dockerfile.quick
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ RUN ln -s /usr/bin/tor /usr/local/bin/tor
# install transports
COPY --from=obfs-builder /out/obfs4proxy /usr/local/bin/.

# create service dir (we don't define VOLUME because https://github.com/docker-library/mysql/issues/255
# and other issues when running as non-root user)
RUN mkdir -p /run/tor/service && chown -R 1001 /run/tor

# change to non root
USER 1001

# create service dir
VOLUME /run/tor/service

ENTRYPOINT ["/usr/local/bin/tor"]
Loading