Benchmarking, packaging, and fix issues, tests and perfomance #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 25, 2020
houndci-bot
reviewed
Jul 25, 2020
houndci-bot
reviewed
Jul 25, 2020
urbanishimwe
force-pushed
the
benchmarking-engine
branch
from
eb3eb07 to
fae93a5
Compare
This was
linked to
issues
Jul 25, 2020
urbanishimwe
force-pushed
the
benchmarking-engine
branch
2 times, most recently
from
186ab87 to
16fbbea
Compare
urbanishimwe
force-pushed
the
benchmarking-engine
branch
2 times, most recently
from
8bb1b2a to
fc533bc
Compare
urbanishimwe
force-pushed
the
benchmarking-engine
branch
from
fc533bc to
936ddeb
Compare
arijitAD
reviewed
Aug 8, 2020
| func TestSetInterfaces(t *testing.T) { | ||
| l := &Listener{} | ||
| l.host = "127.0.0.1" | ||
| l.setInterfaces() |
There was a problem hiding this comment.
Check for errors. This is at multiple places.
There was a problem hiding this comment.
we handled the check at line 30
arijitAD
requested changes
Aug 8, 2020
| } | ||
| origin := &http.Server{ | ||
| Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {}), | ||
| Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| w.Write([]byte("ab")) |
There was a problem hiding this comment.
Error check. Multiple places.
There was a problem hiding this comment.
I handled them with other functionalities to avoid unnecessarily allocation
|
|
||
| func testPcapDumpEngine(f string, t *testing.T) { | ||
| defer os.Remove(f) | ||
| l, err := NewListener(f, 8000, "", EnginePcapFile, true) |
There was a problem hiding this comment.
it's checked at the line 134
urbanishimwe
force-pushed
the
benchmarking-engine
branch
from
0f46a8c to
4f0e08f
Compare
xingren23
referenced
this pull request
in xingren23/goreplay
Sep 4, 2021
### performance - handling of the very big packet(any size that can be buffered) - speeding up TCP sessions by using message hints: Added **proto.HasFullPayload** that helps to validate the entire HTTP request, it supports `Chunked` encoding too! Added **proto.HasRequestTitle** and **proto.HasResponseTitle** for validating the beginning of HTTP request. Those methods are used `input_raw.go` with `TCP`. - supports Keep-Alive: the above functions helps to support keep-alive ### Packaging - **capture:** engines(capture/doc.go) - **tcp:** tcp message parser (tcp/doc.go) ### benchmarking - **capture.BenchmarkPcapDump:** the benchmarks regarding dumping packets in a pcap file - **capture.BenchmarkPcapFile:** the benchmarks of reading packets from a pcap file - **capture.BenchmarkPcap:** the benchmarks of parsing packets from the loopback interface with pcap handles - **proto.BenchmarkHasFullPayload:**: benchmarking this function which validates the HTTP payload - **tcp.BenchmarkPacketParseAndSort:** benchmarks of parsing and sorting packets - **tcp.BenchmarkMessageParserWithoutHint:** benchmarks of message reasembling by using `SYN` and `FIN` flag - **tcp.BenchmarkMessageParserWithHint:** benchmarks of message reasembling by using `proto.HasRequestTitle` and `proto.HasFullPayload` flag ### issues see linked issues ### tests - fixed input raw and engine tests **Most of the changed of the files, was about using functionalities of** `tcp` **and** `capture` **in existing functionalities**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performance
Chunkedencoding too! Added proto.HasRequestTitle and proto.HasResponseTitle for validating the beginning of HTTP request. Those methods are usedinput_raw.gowithTCP.Packaging
benchmarking
SYNandFINflagproto.HasRequestTitleandproto.HasFullPayloadflagissues
see linked issues
tests
Most of the changed of the files, was about using functionalities of
tcpandcapturein existing functionalities