-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter requests using regex on base64 decoded userId:passwd #475
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,14 +10,15 @@ import ( | |
|
||
// HTTPModifierConfig holds configuration options for built-in traffic modifier | ||
type HTTPModifierConfig struct { | ||
urlNegativeRegexp HTTPUrlRegexp | ||
urlRegexp HTTPUrlRegexp | ||
urlRewrite UrlRewriteMap | ||
headerRewrite HeaderRewriteMap | ||
headerFilters HTTPHeaderFilters | ||
headerNegativeFilters HTTPHeaderFilters | ||
headerHashFilters HTTPHashFilters | ||
paramHashFilters HTTPHashFilters | ||
urlNegativeRegexp HTTPUrlRegexp | ||
urlRegexp HTTPUrlRegexp | ||
urlRewrite UrlRewriteMap | ||
headerRewrite HeaderRewriteMap | ||
headerFilters HTTPHeaderFilters | ||
headerNegativeFilters HTTPHeaderFilters | ||
headerBasicAuthFilters HTTPHeaderBasicAuthFilters | ||
headerHashFilters HTTPHashFilters | ||
paramHashFilters HTTPHashFilters | ||
|
||
params HTTPParams | ||
headers HTTPHeaders | ||
|
@@ -55,6 +56,32 @@ func (h *HTTPHeaderFilters) Set(value string) error { | |
return nil | ||
} | ||
|
||
// | ||
// Handling of --http-basic-auth-filter option | ||
// | ||
type basicAuthFilter struct { | ||
regexp *regexp.Regexp | ||
} | ||
|
||
// HTTPHeaderFilters holds list of headers and their regexps | ||
type HTTPHeaderBasicAuthFilters []basicAuthFilter | ||
|
||
func (h *HTTPHeaderBasicAuthFilters) String() string { | ||
return fmt.Sprint(*h) | ||
} | ||
|
||
func (h *HTTPHeaderBasicAuthFilters) Set(value string) error { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. exported method HTTPHeaderBasicAuthFilters.Set should have comment or be unexported |
||
r, err := regexp.Compile(value) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
*h = append(*h, basicAuthFilter{regexp: r}) | ||
|
||
return nil | ||
} | ||
|
||
|
||
// | ||
// Handling of --http-allow-header-hash and --http-allow-param-hash options | ||
// | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment on exported type HTTPHeaderBasicAuthFilters should be of the form "HTTPHeaderBasicAuthFilters ..." (with optional leading article)