-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature flag #336
Feature flag #336
Conversation
Hello! This is a nice feature, and I would love to merge it. However, there are few changes I would like you to make:
|
verbose bool | ||
debug bool | ||
stats bool | ||
exit_after time.Duration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use underscores in Go names; struct field exit_after should be exitAfter
dc3b294
to
776bb28
Compare
Hey @buger, thank for the quick response. Thanks, |
776bb28
to
6620d25
Compare
Do you know why pull requests created from "ghost" user?:) |
Yes, I forked and created the PR with my old user, after I realized that I transferred the repository and closed the old account. |
Merged, thank you! |
Great, thanks! waiting for the next release :) |
New version v0.15.0 include this features. Thanks! |
-timeout flap to support stopping the gortool after n seconds.