Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Only V-Score, no Tabs #8

Closed
dartrax opened this issue Jan 26, 2025 · 5 comments
Closed

FR: Only V-Score, no Tabs #8

dartrax opened this issue Jan 26, 2025 · 5 comments

Comments

@dartrax
Copy link

dartrax commented Jan 26, 2025

I tried to set "Spacing" to "0" as I hoped to get directly adjacted Boards with V-Cuts. The result looked awkward, with V-Cut only on the left side and a red line sitting somehow misplaced at the top...

Image

@buganini
Copy link
Owner

You just found two issues

  1. the red lines are conflicts but the offset is wrong

From https://jlcpcb.com/blog/technical-guidance-v-cut-panelization-standards, the tolerance is 0.4mm so I am not sure if 0 is a good setting, but still
2. I didn't handle zero-gap V-cuts or two very close V-cuts correctly.

@dartrax
Copy link
Author

dartrax commented Jan 26, 2025

Yes 0.4 is better! Would be great if the tool would recognize such small offsets and connect the boards via V-Cut (aka making the "tabs" as long as the V-Cut)

@buganini
Copy link
Owner

Spacing=0 is not trivial to fix, since v-cuts positions are generated in tab building process. I think I'll add a minimum requirement for spacing and merge adjacent v-cuts.

Image

buganini added a commit that referenced this issue Jan 26, 2025
@buganini
Copy link
Owner

V-Cuts merging is implemented, could you test it ?

buganini added a commit that referenced this issue Jan 26, 2025
@dartrax
Copy link
Author

dartrax commented Jan 26, 2025

Looks great, I tested it with my current project and couldn't find any issue. Thank you!

@dartrax dartrax closed this as completed Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants