Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relative path execution #337

Merged
merged 21 commits into from
Feb 5, 2024
Merged

Fix relative path execution #337

merged 21 commits into from
Feb 5, 2024

Conversation

paul-sachs
Copy link
Member

@paul-sachs paul-sachs commented Feb 1, 2024 •
edited
Loading

  • Revert "Revert "Support relative binary path (Support relative binary path #282)""
  • Improved tests and introduced tests for running the binary
  • Updated a bunch of out of date dev dependencies
  • Use official @vscode/test-cli package to run tests
  • Use shell in execSync so references to ./node_modules/.bin/buf execute properly in windows

doriable
doriable reviewed Feb 2, 2024
View reviewed changes
src/get-binary-path.ts Outdated Show resolved Hide resolved
@paul-sachs paul-sachs requested a review from doriable February 2, 2024 22:33
smaye81
smaye81 approved these changes Feb 5, 2024
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
@paul-sachs paul-sachs merged commit 54b6d06 into main Feb 5, 2024
5 checks passed
@paul-sachs paul-sachs deleted the psachs/fix-relative-path branch February 5, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaye81 smaye81 smaye81 approved these changes

@doriable doriable Awaiting requested review from doriable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-sachs @smaye81 @doriable