Match CEL and Go duration literal parsing, while preserving the full range of values #38
Conversation
decode.go
Outdated
| var nanosPerSecond = new(big.Int).SetUint64(uint64(time.Second / time.Nanosecond)) | ||
|
|
||
| var nanosMap = map[string]*big.Int{ | ||
| "ns": new(big.Int).SetUint64(1), |
There was a problem hiding this comment.
Just to be consistent with the rest of the lookups:
| "ns": new(big.Int).SetUint64(1), | |
| "ns": new(big.Int).SetUint64(time.Nanosceond), |
There was a problem hiding this comment.
This is the map to nanoseconds, it converts all the other units to nanos. It just happens to be that time.Nanoseconds is 1, to be consistent this would be:
new(big.Int).SetUint64(uint64(time.Nanosecond / time.Nanosecond)),
but the linter doesn't like that
There was a problem hiding this comment.
I know, but the random magic 1 takes away from the implied documentation. What does the linter complain about?
There was a problem hiding this comment.
I'd also suggest dropping the / time.Nanosecond as well, since it's also redundant if you know about the type.
There was a problem hiding this comment.
Ya, but this conde isn't supposed to know that
There was a problem hiding this comment.
I've added docs to clarify what these values represent (which is the number of nanos in each unit)
There was a problem hiding this comment.
Go's not going to change the unit value to pico's until at least Go2 XD
Matches the impl in time.ParseDuration, except uses a big.Int to support the full range of protobuf Duration values.