Go: fix broken ensure the imports are used when importing multiple packages
#586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although CI is failing for a reason that is probably unrelated to this patch, do I need to do anything? |
h-otter
changed the title
ensure the imports are used breaking when importing multiple packages
h-otter
changed the title
ensure the imports are used breaking when importing multiple packagesensure the imports are used breaking when importing multiple packages
h-otter
changed the title
ensure the imports are used breaking when importing multiple packagesensure the imports are used when importing multiple packages
|
@h-otter thank you so much |
|
Maybe #589 contains a fix of CI failure about zlib version. |
|
@h-otter thanks |
0rax
added a commit
to tifo/protoc-gen-validate
that referenced
this pull request
Jun 2, 2022
0rax
added a commit
to tifo/protoc-gen-validate
that referenced
this pull request
Jun 2, 2022
|
Is there anything else I need to do to get this PR merged? |
|
help |
|
@h-otter longing for this to get merged |
Signed-off-by: h-otter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!!
This PR fixes #585.
This problem is caused by the fact that
enumName (index (externalEnums $) 0)always returns first enum name, even ifenumPackages (externalEnums .)returns multiple packages.With this PR,
enumNamereturns an enum in the specified package.