Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buf plugin push command #3474

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Add buf plugin push command #3474

merged 11 commits into from
Dec 3, 2024

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Nov 14, 2024

This adds the buf plugin push command to upload Buf check plugins to the BSR. Plugins must implement the PluginRPC framework. See the Buf plugins overview for details. The Plugin must be a WebAssembly binary, that implements the check service.

The output for buf plugin push --help:

Push a check plugin to a registry

The first argument is the plugin full name in the format <remote/owner/plugin>.

Usage:
  buf plugin push <remote/owner/plugin> [flags]

Flags:
      --binary string               The path to the Wasm binary file to push.
      --create                      Create the plugin if it does not exist. Defaults to creating a private plugin on the BSR if --create-visibility is not set. Must be used with --create-type.
      --create-type string          The plugin's type setting, if created. Can only be set with --create-type. Must be one of [check]
      --create-visibility string    The module's visibility setting, if created. Can only be set with --create. Must be one of [public,private] (default "private")
  -h, --help                        help for push
      --label strings               Associate the label with the plugins pushed. Can be used multiple times.
      --source-control-url string   The URL for viewing the source code of the pushed plugins (e.g. the specific commit in source control).

This adds the `buf plugin push` command to upload Buf plugins to the
BSR. Only Wasm binary check plugins are supported for now. Plugins
must implement the PluginRPC framework.
@emcfarlane emcfarlane requested a review from doriable November 14, 2024 23:55
Copy link
Contributor

github-actions bot commented Nov 14, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 3, 2024, 9:05 PM

Copy link
Member

@doriable doriable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted offline, some of this should live with bufpluginapi, similar to Upload for modules :)

Copy link
Member

@doriable doriable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@emcfarlane emcfarlane merged commit 1c39351 into main Dec 3, 2024
10 checks passed
@emcfarlane emcfarlane deleted the ed/pluginPushCmd branch December 3, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants