Add --exit-code to buf format #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufdev
commented
Mar 25, 2022
| @@ -1944,19 +1944,6 @@ func TestFormatDiff(t *testing.T) { | |||
| @@ -1,13 +1,7 @@ | |||
| - | |||
| syntax = "proto3"; | |||
|
|
|||
There was a problem hiding this comment.
This test is affected if there is whitespace or not in the diff - this is kind of a mess across IDEs, just simplifying it to test what we need to
bufdev
commented
Mar 25, 2022
| stdoutCopy := bytes.NewBuffer(nil) | ||
| if stdout == nil { |
There was a problem hiding this comment.
This came up as a panic in the tests when I had stdout as nil - this makes it so that stdout/stderr can be nil
doriable
approved these changes
Mar 25, 2022
christophermaier
added a commit
to grapl-security/grapl
that referenced
this pull request
Mar 25, 2022
Now we don't need to go through a helper script, because an `--exit-code` was added with bufbuild/buf#1033. Signed-off-by: Christopher Maier <[email protected]>
wimax-grapl
reviewed
Mar 25, 2022
Comment on lines
+5
to
+6
| - Add `--exit code` flag to `buf format` to exit with a non-zero exit code if | ||
| the files were not already formatted. |
There was a problem hiding this comment.
(you may mean --exit-code not --exit code)
There was a problem hiding this comment.
lol, yes -- we were a bit excited about this. Thanks for catching this and we'll update the changelog :)
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1030.
This makes it so that
buf formatexits with a non-zero exit code if files were not already formatted. Common invocations: