Skip to content

Commit

Permalink
Delete storage.NoExternalPathReadBucket (#2281)
Browse files Browse the repository at this point in the history
  • Loading branch information
bufdev authored Jul 11, 2023
1 parent db9b1fd commit 153c902
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 100 deletions.
79 changes: 0 additions & 79 deletions private/pkg/storage/external_paths.go

This file was deleted.

21 changes: 0 additions & 21 deletions private/pkg/storage/storagetesting/storagetesting.go
Original file line number Diff line number Diff line change
Expand Up @@ -1424,27 +1424,6 @@ func RunTestSuite(
require.True(t, isEmpty)
require.NoError(t, tmpDir.Close())
})
t.Run("no-external-path", func(t *testing.T) {
t.Parallel()
readBucket, getExternalPathFunc := newReadBucket(t, oneDirPath, defaultProvider)
readBucket = storage.MapReadBucket(
readBucket,
storage.MapOnPrefix("root/a"),
)
AssertObjectInfo(
t,
readBucket,
"1.proto",
getExternalPathFunc(t, oneDirPath, filepath.Join("root", "a", "1.proto")),
)
readBucket = storage.NoExternalPathReadBucket(readBucket)
AssertObjectInfo(
t,
readBucket,
"1.proto",
"1.proto",
)
})
t.Run("limit-write-bucket", func(t *testing.T) {
t.Parallel()
writeBucket := newWriteBucket(t, defaultProvider)
Expand Down

0 comments on commit 153c902

Please sign in to comment.