Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: refactor install #349

Merged
1 commit merged into from
Sep 15, 2017
Merged

CMake: refactor install #349

1 commit merged into from
Sep 15, 2017

Conversation

mia-0
Copy link
Collaborator

@mia-0 mia-0 commented Aug 21, 2017

Make it comply with *nix conventions and allow relative data path,
e.g. for AppImage and Windows builds.
Avoid having symlinks in the repository. CMake does not follow them
and they’re poorly supported on Windows.

See #336.

@buddhi1980
Copy link
Owner

@zebastian , can you take care about this pull request?
Check if qmake will still properly (SHARED_DIR is no longed declared by default).

@mia-0
Copy link
Collaborator Author

mia-0 commented Aug 21, 2017

It might not work properly anymore. Sorry about that. I only took care of one of three build systems.

@buddhi1980
Copy link
Owner

I think you can keep symbolic links for another build systems (I havent observed any problems with symlinks under Windows) and also keep default definition of SHARED_DIR (or let us know if it makes problem)
By the way, main build system for this project is qmake, so any changes has to be applied to .pro files, too.
It's good idea to move documentation from /usr/share/mandelbulber/doc to /usr/share/doc/mandelbulber

Make it comply with *nix conventions and allow relative data path,
e.g. for AppImage and Windows builds.
Avoid having symlinks in the repository. CMake does not follow them
and they’re poorly supported on Windows.
@mia-0
Copy link
Collaborator Author

mia-0 commented Aug 21, 2017

The symlinks cause trouble with the CMake install step. It does not follow or update them, and I’d have to maintain a list of subdirectories to be installed to be sure that it works. Not a huge problem, but I thought I’d just avoid the problem altogether.

I have restored the default definition of SHARED_DIR.

@zebastian
Copy link
Collaborator

@lachs0r qmake is broken due to missing formula folder symlink (maybe more erros, this is the first one i got from building from https://github.com/lachs0r/mandelbulber2)
I like your changes, but can you break this into smaller commits, and at the same time keep the builds of other make prerocessors (qmake, msvc) stable?

@mia-0
Copy link
Collaborator Author

mia-0 commented Aug 21, 2017

Will do.

@zebastian
Copy link
Collaborator

great, thank you

@ghost ghost merged commit 25c5aac into buddhi1980:master Sep 15, 2017
@ghost
Copy link

ghost commented Sep 15, 2017

@zebastian I will merge and fix, lets get @lachs0r's first commit in the code base.

@archenroot
Copy link

Hi guys, any progress? last try failed, I am waiting for this CMake support to adopt into Gentoo.

@ghost
Copy link

ghost commented Nov 6, 2017 via email

@zebastian
Copy link
Collaborator

I think, i know what the problem is.
I will try to fix it this evening...

@zebastian
Copy link
Collaborator

@archenroot there was a missing include for cmake, i added it in latest commit: 3617e92
can you try again?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants