-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: refactor install #349
Conversation
@zebastian , can you take care about this pull request? |
It might not work properly anymore. Sorry about that. I only took care of one of three build systems. |
I think you can keep symbolic links for another build systems (I havent observed any problems with symlinks under Windows) and also keep default definition of SHARED_DIR (or let us know if it makes problem) |
Make it comply with *nix conventions and allow relative data path, e.g. for AppImage and Windows builds. Avoid having symlinks in the repository. CMake does not follow them and they’re poorly supported on Windows.
The symlinks cause trouble with the CMake install step. It does not follow or update them, and I’d have to maintain a list of subdirectories to be installed to be sure that it works. Not a huge problem, but I thought I’d just avoid the problem altogether. I have restored the default definition of |
@lachs0r qmake is broken due to missing formula folder symlink (maybe more erros, this is the first one i got from building from https://github.com/lachs0r/mandelbulber2) |
Will do. |
great, thank you |
@zebastian I will merge and fix, lets get @lachs0r's first commit in the code base. |
Hi guys, any progress? last try failed, I am waiting for this CMake support to adopt into Gentoo. |
What are you seeing when you attempt the build for gentoo? The cmake build
works for k1om build/install on centos.
…On Sun, Nov 5, 2017 at 3:09 PM, archenroot ***@***.***> wrote:
Hi guys, any progress? last try failed, I am waiting for this CMake
support to adopt into Gentoo.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#349 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGtt7Q2KlB-YnfJIWsg5ThvTRqxcduFKks5szhXegaJpZM4O8xwd>
.
|
I think, i know what the problem is. |
@archenroot there was a missing include for cmake, i added it in latest commit: 3617e92 |
Make it comply with *nix conventions and allow relative data path,
e.g. for AppImage and Windows builds.
Avoid having symlinks in the repository. CMake does not follow them
and they’re poorly supported on Windows.
See #336.