Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some banks do <CCSTMTRS>...</STMTRS> in their OFX files #378

Closed
iffy opened this issue Mar 13, 2019 · 3 comments
Closed

Some banks do <CCSTMTRS>...</STMTRS> in their OFX files #378

iffy opened this issue Mar 13, 2019 · 3 comments
Labels
included in next release The work is done, it's just waiting to be released. papercut Annoying things
Milestone
Buckets v1.0

Comments

@iffy
Copy link
Contributor

iffy commented Mar 13, 2019 •
edited
Loading

Splitting off second part of #336 to this new issue.

Note to self: you already have a commented-out test in ofx.test.ts
@iffy iffy added the papercut Annoying things label Mar 13, 2019
@iffy iffy changed the title Some banks do <CCSTMTRS></STMTRS> in their OFX files Some banks do <CCSTMTRS>...</STMTRS> in their OFX files Mar 13, 2019
@romainm
Copy link

romainm commented Mar 16, 2019

As the file is currently invalid anyway and cannot be parsed correctly, could you try to apply that fix on the fly if you see that the file is missing the closing tag?

@iffy
Copy link
Contributor Author

iffy commented Mar 16, 2019

@romainm I definitely could, but I'd be worried about a future refactoring removing the exception. Though since I have a good test file for it (thanks to you), I'll give it a go.

@iffy iffy added this to the v1 milestone Dec 1, 2021
@iffy iffy added the included in next release The work is done, it's just waiting to be released. label Feb 10, 2022
@iffy
Copy link
Contributor Author

iffy commented Feb 17, 2022

Included in v0.65.0 release (AUTOMATED COMMENT)

@iffy iffy closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
included in next release The work is done, it's just waiting to be released. papercut Annoying things
Projects
None yet
Milestone
Buckets v1.0
Development

No branches or pull requests
2 participants
@romainm @iffy