Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFX for CBA Australia doesn't import #336

Closed
iffy opened this issue Dec 31, 2018 · 6 comments
Closed

OFX for CBA Australia doesn't import #336

iffy opened this issue Dec 31, 2018 · 6 comments
Labels
bug Things that prevent or seriously impede people from doing their budget. included in next release The work is done, it's just waiting to be released.

Comments

@iffy
Copy link
Contributor

iffy commented Dec 31, 2018

Once I get a sample file, I can fix it.

@iffy iffy added bug Things that prevent or seriously impede people from doing their budget. blocked labels Dec 31, 2018
@romainm
Copy link

romainm commented Jan 1, 2019

Attached example ofx file with a single transaction.
Issue seems to be that the FITID is empty. Looking at much bigger files, that's the case for many transactions but not all of them.
If I remove the transactions with an empty FITID from the file, I can import them properly.

broken_one_statement.ofx.txt

Cheers,
Romain

@romainm
Copy link

romainm commented Jan 1, 2019

And here is a file showing another issue (from another type of account in the same Bank).
This time, the problem seems to be that there is a <CCSTMTRS> tag where there would, for basic Banking account be a <STMTRS>.
Closing tag is still </STMTRS> though.

Manually editing the file to replace CCSTMTRS by STMTRS allows the import to go through. (this files has no empty FITID.)

broken_ccstmtrs.ofx.txt

@iffy
Copy link
Contributor Author

iffy commented Jan 2, 2019

@romainm Thank you for debugging this! I'll get a fix out as soon as I can.

@iffy iffy removed the blocked label Jan 2, 2019
@iffy
Copy link
Contributor Author

iffy commented Mar 13, 2019

@romainm I have a fix in place for the first issue, but I don't know if I can solve the second issue. As you've noted, the problem isn't that <CCSTMTRS> is being used, but rather that they're pairing <CCSTMTRS> with the wrong closing tag </STMTRS>. I'll file a new issue for this one and perhaps a clever fix will come to me (one that doesn't break things for others), but honestly, the bank should fix the file :)

@iffy iffy added the included in next release The work is done, it's just waiting to be released. label Mar 13, 2019
@romainm
Copy link

romainm commented Mar 16, 2019

thanks @iffy, I'm not sure the bank actually cares but I'll raise it as an issue with them (if I can even find the right channel for it)!
I'll add a comment to the new ticket so discussion is tracked properly.

@iffy
Copy link
Contributor Author

iffy commented Mar 17, 2019

Included in v0.55.0 release (AUTOMATED COMMENT)

@iffy iffy closed this as completed Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that prevent or seriously impede people from doing their budget. included in next release The work is done, it's just waiting to be released.
Projects
None yet
Development

No branches or pull requests

2 participants