Skip to content

Commit

Permalink
[metrics] initialize hits/misses for each cache entry kind
Browse files Browse the repository at this point in the history
This makes sure all hit/miss counters appear on the metrics endpoints
and avoids having to fill missing metrics with zero at the client side.
  • Loading branch information
martijndegouw authored and mostynb committed Dec 5, 2023
1 parent 032dd47 commit 3e8f58d
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions cache/disk/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ func WithEndpointMetrics() Option {
[]string{"method", "kind", "status"}),
}

c.metrics.counter.WithLabelValues("get", "cas", "hit").Add(0)
c.metrics.counter.WithLabelValues("get", "cas", "miss").Add(0)
c.metrics.counter.WithLabelValues("contains", "cas", "hit").Add(0)
c.metrics.counter.WithLabelValues("contains", "cas", "miss").Add(0)
c.metrics.counter.WithLabelValues("get", "ac", "hit").Add(0)
c.metrics.counter.WithLabelValues("get", "ac", "miss").Add(0)

return nil
}
}

0 comments on commit 3e8f58d

Please sign in to comment.