-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: embed only used fonts #476
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 62.93% 63.10% +0.17%
==========================================
Files 10 10
Lines 580 580
Branches 143 143
==========================================
+ Hits 365 366 +1
Misses 151 151
+ Partials 64 63 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👋 @tuhm1 💖 Thanks for opening this pull request! 💖 Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
@@ -0,0 +1 @@ | |||
<div style="font-family: Font1"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this line because we must use the font which will be tested in:
html-to-image/test/spec/options.spec.ts
Lines 141 to 152 in 128dc3e
it('should embed only the preferred font', (done) => { | |
bootstrap('fonts/web-fonts/empty.html', 'fonts/web-fonts/remote.css') | |
.then((node) => toSvg(node, { preferredFontFormat: 'woff2' })) | |
.then(getSvgDocument) | |
.then((doc) => { | |
const [style] = Array.from(doc.getElementsByTagName('style')) | |
expect(style.textContent).toMatch(/url\([^)]+\) format\("woff2"\)/) | |
expect(style.textContent).not.toMatch(/url\([^)]+\) format\("woff"\)/) | |
}) | |
.then(done) | |
.catch(done) | |
}) |
@bubkoo could you spare some time? I’d really appreciate it! |
Optimized by embedding only the fonts that are actually used.
Description
The document may have many fonts that are not used by the nodes to be processed. Currently, all fonts are embedded.
Added an optimization that recursively traverses the nodes to find the fonts that are used, then filters out the fonts that are not used before embedding them.
Motivation and Context
This can significantly reduce processing time and the size of the SVG.
Resolves #405, resolves #389, resolves #310
Types of changes
Self Check before Merge