Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update allowedmentions parse type #203

Merged
merged 5 commits into from
Oct 27, 2024
Merged

fix: update allowedmentions parse type #203

merged 5 commits into from
Oct 27, 2024

Conversation

FinnyMarigold58
Copy link
Contributor

@FinnyMarigold58 FinnyMarigold58 requested a review from a team as a code owner October 27, 2024 19:08
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: baf03ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@buape/carbon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the p:carbon The carbon package label Oct 27, 2024
thewilloftheshadow
thewilloftheshadow requested changes Oct 27, 2024
View reviewed changes
Copy link
Member

@thewilloftheshadow thewilloftheshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple command to rocko/cloudo (the test apps in /apps) to test allowed mentions?

Also this PR needs a changeset, you can run pnpm changeset to generate one for @buape/carbon

@thewilloftheshadow thewilloftheshadow added this pull request to the merge queue Oct 27, 2024
Merged via the queue into buape:main with commit d5d1488 Oct 27, 2024
7 checks passed
@FinnyMarigold58 FinnyMarigold58 deleted the fix/finny/allowedmentions-parse-type branch October 27, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilloftheshadow thewilloftheshadow thewilloftheshadow approved these changes

Assignees
No one assigned
Labels
p:carbon The carbon package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allowedMentions doesnt work
2 participants
@FinnyMarigold58 @thewilloftheshadow