Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

54 add a workflow or jobs that run all tests before a merge is done #56

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Apr 2, 2023

Summary

Tests now run for all supported Python versions. Previously the ran only for Python 3.11 - just for time reasons. The mentioned documentations of #54 only work for organisations and since I don't want to move this repository out of my namespace, the only option to ensure that the module runs for all supported Python versions is to run the tests on each commit.

As long there is no free solution (or for user-owned repositories) to run a specific workflow before a merge, this is the only solution I see for now.

Closes #54

@btschwertfeger btschwertfeger added the Could Something that could be cool bit is not really important label Apr 2, 2023
@btschwertfeger btschwertfeger added this to the v1.0.2 milestone Apr 2, 2023
@btschwertfeger btschwertfeger self-assigned this Apr 2, 2023
@btschwertfeger btschwertfeger linked an issue Apr 2, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (40f5e5b) 85.95% compared to head (70b8f4e) 85.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   85.95%   85.95%           
=======================================
  Files          17       17           
  Lines        1339     1339           
=======================================
  Hits         1151     1151           
  Misses        188      188           
Flag Coverage Δ
unittests 85.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@btschwertfeger btschwertfeger marked this pull request as ready for review April 2, 2023 18:14
@btschwertfeger btschwertfeger merged commit 3fefc5b into master Apr 2, 2023
@btschwertfeger btschwertfeger deleted the 54-add-a-workflow-or-jobs-that-run-all-tests-before-a-merge-is-done branch April 2, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Could Something that could be cool bit is not really important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a workflow or jobs that run all tests before a merge is done
1 participant