Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed raising exception when currency not found in portfolio #47

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Removed raising exception when currency not found in portfolio #47

merged 1 commit into from
Mar 30, 2023

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Mar 30, 2023 •
edited
Loading

As described in #46 the forced raising of an exception was removed since it makes more sense to return zero balances when the currency is not found in the actual portfolio than raising an error.

This has occurred when calling the get_balances function of the kraken.spot.client.User client.

@btschwertfeger btschwertfeger self-assigned this Mar 30, 2023
@btschwertfeger btschwertfeger linked an issue Mar 30, 2023 that may be closed by this pull request
Avoid raising ValueError in get_balance if currency is not found in the portfolio #46
Closed
@btschwertfeger btschwertfeger added this to the v1.0.2 milestone Mar 30, 2023
@btschwertfeger btschwertfeger added enhancement New feature or request Should Something that should be implemented somewhere in the future labels Mar 30, 2023
@btschwertfeger btschwertfeger marked this pull request as ready for review March 30, 2023 20:31
@btschwertfeger btschwertfeger merged commit b7c6943 into master Mar 30, 2023
@btschwertfeger btschwertfeger deleted the 46-avoid-raising-valueerror-in-get_balance-if-currency-is-not-found-in-the-portfolio branch March 30, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@btschwertfeger btschwertfeger

Labels
enhancement New feature or request Should Something that should be implemented somewhere in the future
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Avoid raising ValueError in get_balance if currency is not found in the portfolio
1 participant
@btschwertfeger