-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Futures re-subscribe to authenticated feed doesn't work" #180
Merged
btschwertfeger
merged 14 commits into
master
from
179-futures-re-subscribe-to-authenticated-feed-doesnt-work
Dec 18, 2023
Merged
Fix "Futures re-subscribe to authenticated feed doesn't work" #180
btschwertfeger
merged 14 commits into
master
from
179-futures-re-subscribe-to-authenticated-feed-doesnt-work
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btschwertfeger
changed the title
fix the futures ws reconnect issue + add test that checks for that
Fix "Futures re-subscribe to authenticated feed doesn't work"
Dec 18, 2023
btschwertfeger
added
Bug
Something isn't working
Futures
Topic related to Futures trading
Spot
Topic related to Spot trading
Testing
Test-related
labels
Dec 18, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 87.79% 89.73% +1.93%
==========================================
Files 21 21
Lines 1877 1890 +13
==========================================
+ Hits 1648 1696 +48
+ Misses 229 194 -35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
btschwertfeger
deleted the
179-futures-re-subscribe-to-authenticated-feed-doesnt-work
branch
December 18, 2023 18:40
btschwertfeger
added a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR fixes the mentioned bug using the suggested change - as described in #179 by setting the
__challenge_ready
-flag toFalse
in case of a failed task to enforce setting a new challenge and not using the old/broken one.More changes and additions: