Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "163 uniform the msg parameter" #164

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

btschwertfeger
Copy link
Owner

Summary

All parameters named "msg" were renamed to "message". This mostly affects the futures websocket client.

@btschwertfeger btschwertfeger added this to the v2.0.0 milestone Sep 9, 2023
@btschwertfeger btschwertfeger self-assigned this Sep 9, 2023
@btschwertfeger btschwertfeger changed the base branch from master to v2 September 9, 2023 11:35
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #164 (e0899b0) into v2 (a788d3a) will not change coverage.
Report is 1 commits behind head on v2.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2     #164   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files          21       21           
  Lines        1841     1841           
=======================================
  Hits         1667     1667           
  Misses        174      174           
Flag Coverage Δ
unittests 90.54% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
kraken/futures/ws_client.py 33.33%
kraken/spot/websocket/connectors.py 66.66%
kraken/futures/websocket/__init__.py 92.85%

@btschwertfeger btschwertfeger merged commit 8072cb9 into v2 Sep 9, 2023
18 of 25 checks passed
@btschwertfeger btschwertfeger deleted the 163-uniform-the-msg-parameter branch September 9, 2023 13:02
@btschwertfeger btschwertfeger linked an issue Sep 9, 2023 that may be closed by this pull request
@btschwertfeger btschwertfeger added Futures Topic related to Futures trading Spot Topic related to Spot trading labels Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Futures Topic related to Futures trading Spot Topic related to Spot trading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uniform the "msg" parameter
1 participant